-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: read_parquet
and similar methods silently overwrite tables
#9199
Comments
This does seem like a potential footgun. I think with DuckDB, at least, read parquet wouldn't overwrite an existing table, but read_parquet is creating views and we're likely doing a I think an overwrite kwarg is a good idea |
Just to spell this out concretely: There should be an In terms of creating tables / views, we should default to |
@gforsyth Hi I can help some of them But have a question |
HI @alperentahta -- the default for |
@gforsyth thanks for the response, when I keep default register False, unit tests for register is failing, (they are getting the exception we throw during the cases overwrite=False) in this case what should I do? |
How about we just switch to If people want to drop a table or view first we have a method for that. |
@cpcloud Are you talking about doing this inside read parquet, or completely removing table generation capability from read_parquet? |
This would be inside |
What happened?
Here's an example derived from a user issue:
Shouldn't
read_parquet
, etc. just have an overwrite option? If you don't specify that, it should not let you clobber an existing table.What version of ibis are you using?
9.0.0 (initially reported on 8.0.0)
What backend(s) are you using, if any?
DuckDB, but can be replicated on other backends
Relevant log output
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: