Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerendering, going from 1 hole, to no holes doesn't seem to erase the old hole #26

Open
dcorbin opened this issue Nov 20, 2023 · 2 comments

Comments

@dcorbin
Copy link

dcorbin commented Nov 20, 2023

I have situation where I start out with 0 holes, add 1 hole that changes multiple times, and then (through a bug) goes back to 0 holes. At this last stage, passing the empty array of holes does not eliminate the hole from the previous stage. As a workaround, I can create a hole with 0 width/height and that does just fine.

@stephenkopylov
Copy link
Member

@dcorbin thanks for bug report!
It would be really helpful if you'd have created small example app (for example using create-react-native-app) demonstrating this behaviour - we'll try to fix it as soon as possible

@dcorbin
Copy link
Author

dcorbin commented Nov 23, 2023

https://github.com/dcorbin/RNHoleViewBug. Sample App.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants