Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Tekton event handler is too broad #14

Open
oiricaud opened this issue May 19, 2020 · 1 comment
Open

The Tekton event handler is too broad #14

oiricaud opened this issue May 19, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@oiricaud
Copy link
Member

Expand and modified the default event listeners to only trigger a new pipeline run upon a merge of a PR.

Currently the event listener will trigger a webhook on a pipeline run on a push or pr-related activity

@hollisc hollisc added the enhancement New feature or request label May 20, 2020
@hollisc
Copy link
Collaborator

hollisc commented May 20, 2020

Enhancement: The Tekton Trigger resources provided by Kabanero out of the box is very broad (ie. a webhook will be triggered upon every push or activity related to pull requests such as creation, modification, merge, review).

Tweak the Kabanero provided yamls so a webhook is only triggered upon the merging of a PR into a target branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants