Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tests are not swallowing errors #15

Closed
aeweidne opened this issue Sep 6, 2016 · 0 comments
Closed

Ensure tests are not swallowing errors #15

aeweidne opened this issue Sep 6, 2016 · 0 comments

Comments

@aeweidne
Copy link
Contributor

aeweidne commented Sep 6, 2016

Per hubot-ibmcloud-space-management and ibm-cloud-solutions/hubot-ibmcloud-space-management#17, the tests in this repo need to be investigated and probably updated if they are found to be swallowing errors or not surfacing them through the test runner correctly. The recommended practice is to use the portend library used in hubot-ibmcloud-space-management in order to test the emits generated by our scripts. This practice is outlined in the contributing.md of hubot-ibmcloud-space-management. When the tests are updated here, the contributing.md of this project must be updated as well.'

@aeweidne aeweidne closed this as completed Sep 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant