Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popup: 'show tall drop down button', popup too tall on subsequent opening of the popup #360

Closed
lbod opened this issue Jan 8, 2015 · 2 comments

Comments

@lbod
Copy link
Member

lbod commented Jan 8, 2015

  1. load delite/tests/functional/popup.html in your browser
  2. resize the browser to the point where the show tall drop down button button shows the popup above the button.
  3. once you're at that point, reload the page and launch the show tall drop down button popup
  4. close the popup (focussing elsewhere on the page)
  5. launch the show tall drop down button popup again you should see the popup obscures the button.

This is related to #347

The first launch shows:
screen shot 2015-01-08 at 23 20 44

The next launch shows:

screen shot 2015-01-08 at 23 20 59

A simple change again is needed to https://github.com/ibm-js/delite/blob/master/popup.js#L422 e.g.

from:

wrapper.style.height = args._naturalHeight > maxHeight ? maxHeight + "px" : "auto";

to:

wrapper.style.height = args._naturalHeight >= maxHeight ? maxHeight + "px" : "auto";
@lbod lbod changed the title 'show tall drop down button' sets height auto on subsequent loads 'show tall drop down button' sets height auto on subsequent opening of the popup Jan 8, 2015
@lbod lbod changed the title 'show tall drop down button' sets height auto on subsequent opening of the popup popup: 'show tall drop down button' sets height auto on subsequent opening of the popup Jan 9, 2015
@wkeese
Copy link
Member

wkeese commented Jan 9, 2015

Again, your change doesn't look right. The naturalHeight should be something like 2000, and the maxHeight should be something like 400, so > and >= should return the same result.

@wkeese wkeese changed the title popup: 'show tall drop down button' sets height auto on subsequent opening of the popup popup: 'show tall drop down button', popup too tall on subsequent opening of the popup Jan 12, 2015
@wkeese
Copy link
Member

wkeese commented Nov 12, 2018

This works correctly now; it actually started working correctly in ee21727.

@wkeese wkeese closed this as completed Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants