Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mas install should enforce rules for MAS "Instance ID" and "workspace ID" #244

Closed
racree opened this issue Apr 18, 2023 · 2 comments · Fixed by #402
Closed

mas install should enforce rules for MAS "Instance ID" and "workspace ID" #244

racree opened this issue Apr 18, 2023 · 2 comments · Fixed by #402
Assignees

Comments

@racree
Copy link
Contributor

racree commented Apr 18, 2023

While installing MAS and Manage, entering a MAS instance id such as 810instance will cause ManageDeployment to fail with the message "Service "810instance-mas-maxinst" is invalid: metadata.name: Invalid value...

a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?')

mas install should reject invalid values for instance id rather than proceeding and have the ManageDeployment fail

the mas cli should also validate the workspace id.

@racree racree changed the title mas install should enforce rules for Manage "Instance ID" mas install should enforce rules for MAS "Instance ID" Apr 18, 2023
@racree
Copy link
Contributor Author

racree commented Apr 18, 2023

Optimizer will also fail with
"Service \"810instance-api\" is invalid: metadata.name: Invalid value: \"810instance-api\": a DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?')","reason":

@racree
Copy link
Contributor Author

racree commented Apr 18, 2023

VisualInspectionApp also fails with
DNS-1035 label must consist of lower case alphanumeric characters or '-', start with an alphabetic character, and end with an alphanumeric character (e.g. 'my-name', or 'abc-123', regex used for validation is 'a-z?')

@racree racree changed the title mas install should enforce rules for MAS "Instance ID" mas install should enforce rules for MAS "Instance ID" and "workspace ID" Jun 2, 2023
@durera durera self-assigned this Aug 8, 2023
@durera durera linked a pull request Aug 8, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants