Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GUI : FED : Table check boxes label accessibility violations #2756

Closed
10 tasks
derick-montague opened this issue Nov 11, 2020 · 1 comment
Closed
10 tasks

GUI : FED : Table check boxes label accessibility violations #2756

derick-montague opened this issue Nov 11, 2020 · 1 comment
Assignees
@dixsie
Labels
GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone prio_high UI FED Indicates a GUI Front End Development story
Milestone
Sprint 2020-24

Comments

@derick-montague
Copy link
Contributor

derick-montague commented Nov 11, 2020 •
edited

Overview

The check boxes used for all the tables do not meet accessibility guidelines.

  1. The check boxes in the table rows are missing a label value.
    image.png

  2. The select all check box is missing a label
    image

Tasks

  • Run the IBM accessibility checker and resolve all the checkbox accessibility violations
  • Table header label select all or unselect all
  • Row label select or unselect
  • Check with IBM language guidelines to determine if term unselect or deselect is the proper verb
  • Identify and update all tables throughout the application

UX Flow / Interaction Requirements

N/A

Final Invision Mockup

N/A

cURL Commands

N/A

Notes

UI Checklist

Browser Tests (Chrome, Firefox, Safari (Mac), Edge (Windows))

  • Tested responsive layout on supported viewport sizes
  • Verified functionality works as expected, e.g. success and failure use cases
  • Resolved any JavaScript errors thrown to the console

Accessibility Tests
@derick-montague derick-montague added GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone prio_high UI FED Indicates a GUI Front End Development story labels Nov 11, 2020
@derick-montague derick-montague added this to the A.1.204 milestone Nov 11, 2020
@derick-montague derick-montague changed the title GUI : FED : Table check boxes do not have an associated label GUI : FED : Table check boxes labels do not have descriptive text Nov 11, 2020
@derick-montague derick-montague changed the title GUI : FED : Table check boxes labels do not have descriptive text GUI : FED : Table check boxes label accessibility violations Nov 11, 2020
@dixsie
Copy link
Contributor

dixsie commented Nov 19, 2020

resolved by: https://gerrit.openbmc-project.xyz/c/openbmc/webui-vue/+/38439

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dixsie dixsie

Labels
GUI Catch all tag for GUI stories Milestone Tgt Overrides Epic Milestone prio_high UI FED Indicates a GUI Front End Development story
Projects
None yet
Milestone
Sprint 2020-24
Development

No branches or pull requests
2 participants
@derick-montague @dixsie