Telemetry: Calculated (Min, Max, Average)

[gtmills]

A Telemetry service is being added here:
https://gerrit.openbmc-project.xyz/q/topic:%22telemetry%22+(status:open%20OR%20status:merged)

One thing it is missing is the ability to do "Calculated " metrics, specifically Min, Max, and Average.

These are defined in the https://redfish.dmtf.org/schemas/v1/MetricReportDefinition.v1_4_0.json

These will need to work with the CollectionTimeScope, etc.

        "CalculationAlgorithmEnum": {
            "description": "The function to apply to the list of metric properties.",
            "enum": [
                "Average",
                "Maximum",
                "Minimum",
                "Summation"
            ],
            "enumDescriptions": {
                "Average": "The metric is calculated as the average metric reading over a duration.",
                "Maximum": "The metric is calculated as the maximum metric reading over a duration.",
                "Minimum": "The metric is calculated as the minimum metric reading over a duration.",
                "Summation": "The metric is calculated as the sum of the values over a duration."
            },
            "enumLongDescriptions": {
                "Average": "This value shall indicate the metric is calculated as the average metric reading over a duration.  The duration shall be the CollectionDuration property value.",
                "Maximum": "This value shall indicate the metric is calculated as the maximum metric reading over a duration.  The duration shall be the CollectionDuration property value.",
                "Minimum": "This value shall indicate the metric is calculated as the minimum metric reading over a duration.  The duration shall be the CollectionDuration property value.",
                "Summation": "This value shall indicate the metric is calculated as the sum of the specified metric reading over a duration.  The duration shall be the CollectionDuration property value."
            },
            "longDescription": "This type shall specify the function to apply to the list of metric properties.",
            "type": "string"
        },

These changes will need to happen in bmcweb and the telemetry repo.
Please work with the community on these changes.

When this is complete a client should be able to sign up for a max over 30 seconds of CPU temperatures or a 1 min average of the inlet temperature

Additional references:
https://www.dmtf.org/documents/redfish-spmf/redfish-telemetry-white-paper-0
https://redfish.dmtf.org/redfish/mockups/v1/1027
https://lists.ozlabs.org/pipermail/openbmc/2021-February/025141.html

[gtmills]

@lxwinspur @ChicagoDuan @XiaochaoMa Is there an owner for this?
Could the owner review / test https://gerrit.openbmc-project.xyz/c/openbmc/telemetry/+/41064 ?

[lxwinspur]

Could the owner review / test https://gerrit.openbmc-project.xyz/c/openbmc/telemetry/+/41064 ?

Sure, Let me review / test this patch.

[lxwinspur]

@gtmills

I saw that Intel has implemented this function, could you take a look at this patch?

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/46349/5/redfish-core/lib/metric_report_definition.hpp#32

[gtmills]

@lxwinspur I will take a look, can you review as well?

[lxwinspur]

@lxwinspur I will take a look, can you review as well?

Yes, I am testing

[lxwinspur]

@gtmills
https://redfish.dmtf.org/redfish/mockups/v1/1027
This link is no longer valid

[gtmills]

https://redfish.dmtf.org/redfish/v1 are the mockups

[lxwinspur]

@gtmills can we close this issue?

[gtmills]

@lxwinspur Has this been merged upstream ?

[lxwinspur]

@lxwinspur Has this been merged upstream ?

No, still reviewing
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/44270/

[gtmills]

Let's use this to track getting in.
Since we have this downstream, I moved this to Code Review in Driver. I also lowered the priority since we have this downstream

[gtmills]

This commit merged.
See this at https://github.com/search?q=repo%3Aopenbmc%2Fbmcweb+Minimum+language%3AC%2B%2B&type=code&l=C%2B%2B
Closing