Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor enhancements #178

Merged
merged 1 commit into from
Jan 25, 2024
Merged

fix: minor enhancements #178

merged 1 commit into from
Jan 25, 2024

Conversation

francinelucca
Copy link
Contributor

@francinelucca francinelucca commented Jan 24, 2024 •
edited

Closes #174 , Closes #175

Changelog

Changed

  • Cleanup sort strategy in src/main/scopes/jsx/jsx-scope.ts
  • Place comment in correct location src/main/scopes/npm/get-dependency-tree.ts

Testing / reviewing

N/A

@francinelucca francinelucca requested a review from a team as a code owner January 24, 2024 23:32
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@francinelucca francinelucca merged commit 3fec8cc into main Jan 25, 2024
6 checks passed
@francinelucca francinelucca deleted the 174-jsxscope-move-comment branch January 25, 2024 15:34
@telemmy telemmy bot mentioned this pull request Jan 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdharvey-ibm jdharvey-ibm jdharvey-ibm approved these changes

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve sort syntax JsxScope - Move Comment
2 participants
@francinelucca @jdharvey-ibm