Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display() - mapbox hover "help" doesn't display non-numeric data #203

Closed
ptitzler opened this issue Mar 1, 2017 · 5 comments
Closed

display() - mapbox hover "help" doesn't display non-numeric data #203

ptitzler opened this issue Mar 1, 2017 · 5 comments
Assignees
Milestone

Comments

@ptitzler
Copy link
Contributor

ptitzler commented Mar 1, 2017

0.86 (not data set specific)

import pixiedust
df=pixiedust.SampleData(2)
display(df)
  • Select Map chart type
  • As keys select Longitude and Latitude
  • As value select a numeric field (e.g. price) and a non-numeric field (e.g. name)
  • Choose mapbox as renderer
  • Hover over a marker

Expected behavior

The hover help/tool tip displays the values for the selected numeric field (e.g. price) and non-numeric field (e.g. name).

Actual behavior

The hover help/tool tip displays the values for the selected numeric field (e.g. price) only.

Steps to reproduce the behavior

@ptitzler ptitzler added the bug label Mar 1, 2017
@DTAIEB DTAIEB added this to the 1.1 milestone Mar 1, 2017
@isc-rsingh
Copy link
Member

Requires a re-work of the options for mapping. Probable fix is adding a new option for mapping renderers that allows user to specify fields only for pop-up display.

@vabarbosa
Copy link
Member

vabarbosa commented Jan 29, 2018

@DTAIEB i believe the problem here is the default implementation of baseChartDisplay.getValueFields() removes all non-numeric valueFields columns. map renderers (or any renderer which allows non numeric valueFields) should either use

  • a different implementation of getValueFields (which does not remove non-numeric columns if aggregation is not supported)
    or
  • move/place non-numeric columns into the 'preserveCols' field

@vabarbosa
Copy link
Member

@glynnbird we have this, if you want to try another

@glynnbird
Copy link
Member

Slightly modified instructions to reproduce:

import pixiedust
df=pixiedust.sampleData(2)
display(df)
  • Select Map chart type
  • As keys select Longitude and Latitude
  • As value select a numeric field (e.g. price) and a non-numeric field (e.g. name)
  • Choose mapbox as renderer
  • Hover over a marker

@isc-rsingh
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants