Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating docs/README.md #46

Closed
abmusse opened this issue Oct 25, 2018 · 1 comment
Closed

Updating docs/README.md #46

abmusse opened this issue Oct 25, 2018 · 1 comment
Labels
enhancement New feature or request minor

Comments

@abmusse
Copy link
Member

abmusse commented Oct 25, 2018

Original report by me.


This issue is a follow up to Issue #24

Currently this is a straight port from developerWorks.

I'm creating this issue to list what I think should be updated & for others to also make suggestions.

Examples

  1. replace require('/QOpenSys/QIBM/ProdData/OPS/Node4/os400/db2i/lib/db2a') with
    require('idb-connector')

  2. replace var declarations with let and const as appropriate.

  3. use single quotes instead of double quotes

  4. Remove concurrent query example - documented here that this can be bad!

#Docs

  1. update execute() syntax to show execute(out, error)

  2. Some of the methods have duplicates for their syntaxes:

For example:

prepare(string SQL, function Callback())

prepare(string SQL, function Callback(Error))

Would change to only show: prepare(string SQL, function Callback(Error)).

@abmusse
Copy link
Member Author

abmusse commented Dec 27, 2018

resolved in PR #10

@abmusse abmusse closed this as completed Dec 27, 2018
@abmusse abmusse added minor enhancement New feature or request labels Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant