-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add idb-connector to Dependencies in Package.json #13
Comments
Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell). I think the reason we originally didn't put it as a dependency is because the iToolkit can be used in an HTTP scenario where idb-connector isn't required. With that said, it is much more often the case that the iToolkit is used in scenarios where idb-connector is required so I am in favor of this change. |
Seems like this would be sufficient: https://docs.npmjs.com/files/package.json#optionaldependencies |
So on non ibm i systems itoolkit will still install properly even though idb-connector wont install. |
Moved |
Original report by me.
Package.json Should list idb-connector as a dependancy because it is required on line 50 of istroedp.js.
That way if someone npm installs itoolkit without already having idb-connector it will work.
The text was updated successfully, but these errors were encountered: