Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add idb-connector to Dependencies in Package.json #13

Closed
abmusse opened this issue May 24, 2018 · 5 comments
Closed

Add idb-connector to Dependencies in Package.json #13

abmusse opened this issue May 24, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@abmusse
Copy link
Member

abmusse commented May 24, 2018

Original report by me.


Package.json Should list idb-connector as a dependancy because it is required on line 50 of istroedp.js.

#!js
  db = require('idb-connector');

That way if someone npm installs itoolkit without already having idb-connector it will work.

@abmusse
Copy link
Member Author

abmusse commented May 29, 2018

Original comment by Aaron Bartell (Bitbucket: aaronbartell, GitHub: aaronbartell).


I think the reason we originally didn't put it as a dependency is because the iToolkit can be used in an HTTP scenario where idb-connector isn't required. With that said, it is much more often the case that the iToolkit is used in scenarios where idb-connector is required so I am in favor of this change.

@abmusse
Copy link
Member Author

abmusse commented Sep 18, 2018

Original comment by Xu Meng (Bitbucket: mengxumx, GitHub: dmabupt).


@ThePrez what's your opinion?

@abmusse abmusse added minor enhancement New feature or request labels Jan 22, 2019
@kadler
Copy link
Member

kadler commented Jan 22, 2019

Seems like this would be sufficient: https://docs.npmjs.com/files/package.json#optionaldependencies

@abmusse
Copy link
Member Author

abmusse commented Jan 22, 2019

Seems like this would be sufficient: https://docs.npmjs.com/files/package.json#optionaldependencies

So on non ibm i systems itoolkit will still install properly even though idb-connector wont install.

@kadler kadler removed the minor label Jan 24, 2019
@abmusse
Copy link
Member Author

abmusse commented Mar 4, 2019

Moved idb-connector to optional deps in 85a2e54

@abmusse abmusse closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants