Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config unused_tag is confusing #170

Closed
jormaechea opened this issue Jun 16, 2020 · 4 comments
Closed

Config unused_tag is confusing #170

jormaechea opened this issue Jun 16, 2020 · 4 comments

Comments

@jormaechea
Copy link
Contributor

Shouldn't be it undefined_tag? Because that's what that config checks:

Flag a tag that is in operations and not listed in tags on the top level.

IMO, unused_tag could be a new rule that performs the following check:

Flag a tag that is listed in tags on the top level, but not used by any operation.

What do you think? I know it's a breaking change, but you're still in v0.x.x..

@dpopp07
Copy link
Member

dpopp07 commented Jun 19, 2020

@jormaechea thanks for opening the issue. I think you're right about that and since we're still technically in "pre-release" I'm not opposed to making a breaking change.

Is this something you could open a PR for? I'm having trouble prioritizing this tool at the moment but I would be happy to review a PR.

@jormaechea
Copy link
Contributor Author

Sure, I’ll let you know when it's ready!

jormaechea added a commit to jormaechea/openapi-validator that referenced this issue Jun 20, 2020
@jormaechea
Copy link
Contributor Author

@dpopp07 we should close this, right?

@dpopp07
Copy link
Member

dpopp07 commented Jun 29, 2020

Yep, thought I already had. Thanks for the reminder!

@dpopp07 dpopp07 closed this as completed Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants