Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistent_property_type is too aggressive, with no individual way to skip #181

Closed
hudlow opened this issue Jul 31, 2020 · 4 comments · Fixed by #230
Closed

inconsistent_property_type is too aggressive, with no individual way to skip #181

hudlow opened this issue Jul 31, 2020 · 4 comments · Fixed by #230
Labels

Comments

@hudlow
Copy link
Member

hudlow commented Jul 31, 2020

Especially where generic, context-sensitive property names are used, such as code, inconsistent_property_type property type can lead to false positives across unrelated schemas. I believe we ought to rethink how this check works, or provide a way to skip the check for specific properties.

@dpopp07
Copy link
Member

dpopp07 commented Oct 7, 2020

The proposed solution here is to provide a list of values that we ignore this warning for. This could also be made configurable.

@jorge-ibm
Copy link
Contributor

Mirrored issue on sdk board: https://github.ibm.com/arf/planning-sdk-squad/issues/2375

@hudlow
Copy link
Member Author

hudlow commented Jan 25, 2021

Not a very long list, but here are the property names I am familiar with that run afoul of this rule despite somewhat legitimate reasons for having varying types:

default
value
code
type

@dpopp07
Copy link
Member

dpopp07 commented Jan 26, 2021

🎉 This issue has been resolved in version 0.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants