Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs of dimensions of decoder RNN are wrong #50

Closed
kylegao91 opened this issue Aug 4, 2017 · 1 comment
Closed

Docs of dimensions of decoder RNN are wrong #50

kylegao91 opened this issue Aug 4, 2017 · 1 comment
Assignees
Milestone

Comments

@kylegao91
Copy link
Contributor

kylegao91 commented Aug 4, 2017

  • inputs should have size (batch_size, seq_len, hidden_size) since RNN is set to be batch first.
  • encoder_hidden should be (num_layers * num_direction, batch_size, hidden_size)
  • decoder_outputs should be (seq_len, batch_size, vocab_size)
@kylegao91 kylegao91 mentioned this issue Aug 10, 2017
@kylegao91 kylegao91 assigned kylegao91 and unassigned kpfadnis Aug 10, 2017
@kylegao91 kylegao91 added this to the Sprint 2 milestone Aug 10, 2017
@yucoian
Copy link

yucoian commented Mar 15, 2018

I also think the docs are easily misleading in decoderRNN especially. I suggest add more description on the decoderRNN class's member function , its inputs and outputs. The rest docs are really nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants