Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom rules config does not working #102

Closed
CatsMiaow opened this issue Oct 19, 2020 · 2 comments
Closed

Custom rules config does not working #102

CatsMiaow opened this issue Oct 19, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@CatsMiaow
Copy link

https://ibm.github.io/report-toolkit/config/#customizing-the-%22recommended%22-configuration

The setting values below do not working
.rtkrc.js

exports.config = ['rtk:recommended', {
  rules: {
    'cpu-usage': true,
    'library-mismatch': false,
    'long-timeout': true,
    'memory-usage': true,
  },
}];
rtk --rc .rtkrc.js inspect report1.json

function toRuleConfig(config = {}) {
const ruleIdsCount = _.getOr(0, 'rules.length', config);

Since the passed config.rules value is an object, there is no length property, so ruleIdsCount always returns 0

@boneskull
Copy link
Contributor

hmm, okay, I'll look at this. thanks

@boneskull boneskull added the bug Something isn't working label Jan 7, 2021
@boneskull boneskull self-assigned this Jan 7, 2021
@boneskull
Copy link
Contributor

confirmed. will have a fix out shortly

boneskull added a commit that referenced this issue Jan 7, 2021
- fix doc generation
- downgrade `typedoc-plugin-markdown`
boneskull added a commit that referenced this issue Jan 7, 2021
- fix doc generation
- downgrade `typedoc-plugin-markdown`
boneskull added a commit that referenced this issue Jan 8, 2021
- fix doc generation
- downgrade `typedoc-plugin-markdown`
boneskull added a commit that referenced this issue Jan 8, 2021
- fix doc generation
- downgrade `typedoc-plugin-markdown`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants