Skip to content
This repository has been archived by the owner on Dec 28, 2021. It is now read-only.

Do you have a branch in Mumbai? -> Sorry currently we don't have branch details for undefined #138

Closed
markstur opened this issue Mar 2, 2020 · 0 comments · Fixed by #140
Closed

Do you have a branch in Mumbai? -> Sorry currently we don't have branch details for undefined #138

markstur opened this issue Mar 2, 2020 · 0 comments · Fixed by #140
Assignees
@markstur

Comments

@markstur
Copy link
Contributor

markstur commented Mar 2, 2020

2 problems...

  1. "undefined" is just a coding error on that error message. In this case it has a location to use.

  2. Why not return details for Mombai? This is happening because this pattern was split into US/India versions. The India version has both Mombai and NY while the US version is just unable to return details when specifically asked about Mombai. Why not answer?
@markstur markstur self-assigned this Mar 2, 2020
markstur added a commit that referenced this issue Mar 2, 2020
@markstur
Fix branchLookup for Mumbai
a8136eb 
Fixes #138

* The error message had undefined instead of the location
* Allow the US version to have both branches like the India version does.
@markstur markstur mentioned this issue Mar 2, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@markstur markstur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix branchLookup for Mumbai IBM/watson-banking-chatbot
1 participant
@markstur