Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixtures of timestamps depending on API #18

Closed
cmgrote opened this issue Jan 4, 2021 · 1 comment
Closed

Mixtures of timestamps depending on API #18

cmgrote opened this issue Jan 4, 2021 · 1 comment
Assignees
@cmgrote
Labels
bug Something isn't working

Comments

@cmgrote
Copy link
Contributor

cmgrote commented Jan 4, 2021

Different API endpoints (more specifically, their payload structures) seem to use different timestamp formats -- some include millisecond-level detail, and others do not. To handle serde timestamps reliably, we probably need to annotate every date in the model accordingly as to whether it includes (or not) the millisecond-level detail.
@cmgrote cmgrote added the bug Something isn't working label Jan 4, 2021
@cmgrote cmgrote self-assigned this Jan 4, 2021
@cmgrote cmgrote mentioned this issue Jan 4, 2021
Merged
@cmgrote
Copy link
Contributor Author

cmgrote commented Jan 14, 2021

Think I've found a simpler way of addressing this, via #25

@cmgrote cmgrote closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmgrote cmgrote

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmgrote