Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locking #71

Closed
iBotPeaches opened this issue Nov 29, 2021 · 1 comment · Fixed by #96
Closed

Locking #71

iBotPeaches opened this issue Nov 29, 2021 · 1 comment · Fixed by #96
Labels
enhancement New feature or request

Comments

@iBotPeaches
Copy link
Owner

I think folks normally on initial load click a different tab immediately, while the background initial data pull is still going. This leads to one of the connections failing with DB collision.

We could setup mutex here to hold them waiting till first is done.
@iBotPeaches iBotPeaches added the enhancement New feature or request label Nov 29, 2021
@iBotPeaches iBotPeaches mentioned this issue Nov 29, 2021
Closed
@iBotPeaches
Copy link
Owner Author

I think a lockedForUpdate would work great here, but at the same time we kick off the background matches sync. If we touch the parent Player, this might lead to some issues within the transaction.

Need to think through this.

@iBotPeaches iBotPeaches mentioned this issue Dec 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lock DB during Player/Game Updates iBotPeaches/LeafApp_Infinite
1 participant
@iBotPeaches