Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor heat transfer coefficient alpha in aixlib models #1168

Closed
katharinabr opened this issue Jul 10, 2019 · 3 comments · Fixed by #1183
Closed

Refactor heat transfer coefficient alpha in aixlib models #1168

katharinabr opened this issue Jul 10, 2019 · 3 comments · Fixed by #1183
Assignees
@katharinabr

Comments

@katharinabr
Copy link
Contributor

In some AixLib models the heat transfer coefficient alpha becomes hConv or hRad according to https://github.com/RWTH-EBC/AixLib/wiki/Variable-Naming. This should also be done in IBPSA.ThermalZones.ReducedOrder to avoid problems at the next IBPSA/ AixLib merge.
@mwetter
Copy link
Contributor

mwetter commented Jul 10, 2019

@katharinabr : Could you use hCon to stick with the 3 letter camel-case convention that we try to use (but admittedly don't use consistently)?

@katharinabr
Copy link
Contributor Author

Ok, I'll use hCon. We just thought there might be some confusion because we already use Con, e.g. for condenser. But I think the context shows what is meant.

@katharinabr katharinabr mentioned this issue Jul 11, 2019
Closed
@mwetter
Copy link
Contributor

mwetter commented Jul 12, 2019

The development branch is issue1168_RefactorAlpha

@mwetter mwetter mentioned this issue Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katharinabr katharinabr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue1168 refactor alpha ibpsa/modelica-ibpsa
Issue1168 refactor alpha
2 participants
@mwetter @katharinabr