Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kFixed final in PartialTwoWayValve and CheckValve #1472

Open
AntoineGautier opened this issue Apr 26, 2021 · 0 comments
Open

Make kFixed final in PartialTwoWayValve and CheckValve #1472

AntoineGautier opened this issue Apr 26, 2021 · 0 comments
Assignees

Comments

@AntoineGautier
Copy link
Contributor

AntoineGautier commented Apr 26, 2021

In IBPSA.Fluid.Actuators.BaseClasses.PartialTwoWayValve and IBPSA.Fluid.FixedResistances.CheckValve it seems that the following declaration should be made final.

  parameter Real kFixed(unit="", min=0) = if dpFixed_nominal > Modelica.Constants.eps
    then m_flow_nominal / sqrt(dpFixed_nominal) else 0
    "Flow coefficient of fixed resistance that may be in series with valve, k=m_flow/sqrt(dp), with unit=(kg.m)^(1/2).";

I do not any see any use case where the user should be allowed to modify that assignment.
Also, the class IBPSA.Fluid.Actuators.BaseClasses.PartialDamperExponential uses the following.

  final parameter Real kFixed = if dpFixed_nominal > Modelica.Constants.eps then 
    m_flow_nominal / sqrt(dpFixed_nominal) else Modelica.Constants.inf
    "Flow coefficient of fixed resistance that may be in series with damper, k=m_flow/sqrt(dp), with unit=(kg.m)^(1/2).";
@AntoineGautier AntoineGautier self-assigned this Apr 26, 2021
@AntoineGautier AntoineGautier changed the title Make kFixed final in PartialTwoWayValve Make kFixed final in PartialTwoWayValve and CheckValve Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant