Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assigned parameter riseTime in valve instances #1663

Merged
merged 1 commit into from Nov 23, 2022
Merged

Assigned parameter riseTime in valve instances #1663

merged 1 commit into from Nov 23, 2022

Conversation

mwetter
Copy link
Contributor

@mwetter mwetter commented Nov 16, 2022

This closes #1662

@mwetter mwetter requested a review from cvering November 18, 2022 00:09
cvering
cvering approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@cvering cvering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mwetter ! Thanks for updating this issue.

@mwetter mwetter merged commit 5f8fbf1 into master Nov 23, 2022
@mwetter mwetter deleted the issue1662_valveRiseTime branch November 23, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvering cvering cvering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Actuators.BaseClasses.PartialThreeWayValve does not assign riseTime
2 participants
@mwetter @cvering