-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Obsolete dynamicBalance parameter #411
Comments
+1 :) |
I am in favor of removing I will assign it to @rubenbaetens . Please also update the release notes of the models. (I however think we should be careful to have backwards compatibility where meaningful as |
We also plan to have a non-backward compatible release of |
Following models still contain the
|
Closed in #412 |
Some models (e.g.
Fluid.Movers.FlowControlled_m_flow
) still have a parameterdynamicBalance
which overwritesenergyDynamics
andmassDynamics
if false.I think the parameter is still there to be backwards compatible with older versions of the
Annex60
library, but it's my personal opinion that, as long as there is no official release version of the library, backwards compatibility should not be considered. In that case, i would suggest to remove thedynamicBalance
parameter everywhere.The text was updated successfully, but these errors were encountered: