Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete dynamicBalance parameter #411

Closed
rubenbaetens opened this issue Feb 10, 2016 · 5 comments
Closed

Obsolete dynamicBalance parameter #411

rubenbaetens opened this issue Feb 10, 2016 · 5 comments
Assignees

Comments

@rubenbaetens
Copy link
Contributor

Some models (e.g. Fluid.Movers.FlowControlled_m_flow) still have a parameter dynamicBalance which overwrites energyDynamics and massDynamics if false.

I think the parameter is still there to be backwards compatible with older versions of the Annex60 library, but it's my personal opinion that, as long as there is no official release version of the library, backwards compatibility should not be considered. In that case, i would suggest to remove the dynamicBalance parameter everywhere.

@Mathadon
Copy link
Member

+1 :)

@mwetter
Copy link
Contributor

mwetter commented Feb 11, 2016

I am in favor of removing dynamicBalance as I think it is clearer to simply have energyDynamics and massDynamics rather than having a parameter overwrite the functionality of another parameter.

I will assign it to @rubenbaetens . Please also update the release notes of the models.

(I however think we should be careful to have backwards compatibility where meaningful as Buildings and maybe other libraries have official releases. Next month we plan to have a non-backwards compatible release of Buildings. Hence it would be good to get this change and any other non-backwards compatible changes done.)

@rubenbaetens
Copy link
Contributor Author

We also plan to have a non-backward compatible release of IDEAS next month, so perfect timing here.

@rubenbaetens
Copy link
Contributor Author

Following models still contain the dynamicBalance parameter:

  • Annex60.Fluid.Movers.BaseClasses.PartialFlowMachine
  • Annex60.Fluid.HeatExchangers.Examples.BaseClasses.Heater
  • Annex60.Fluid.BaseClasses.PartialThreeWayResistance

mwetter added a commit that referenced this issue Feb 20, 2016
mwetter added a commit that referenced this issue Feb 20, 2016
mwetter added a commit that referenced this issue Feb 23, 2016
mwetter added a commit that referenced this issue Feb 23, 2016
@Mathadon
Copy link
Member

Closed in #412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants