Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate model in Psychometrics? #475

Closed
Mathadon opened this issue May 24, 2016 · 4 comments · Fixed by #573
Closed

Duplicate model in Psychometrics? #475

Mathadon opened this issue May 24, 2016 · 4 comments · Fixed by #573

Comments

@Mathadon
Copy link
Member

It seems as if Annex60.Utilities.Psychrometrics.WetBul_pTX and Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi are more or less identical models. Can we remove either of the two? I suggest the former.

@mwetter
Copy link
Contributor

mwetter commented May 27, 2016

From my point of view, Annex60.Utilities.Psychrometrics.WetBul_pTX can be deleted as all computations can also be done using Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi.
The only capability that Annex60.Utilities.Psychrometrics.TWetBul_TDryBulXi adds is to output X at the wet bulb temperature, which can also be computed using X_pTphi.

@thorade , @mlauster : Is UdK Berlin and Aachen OK with removing Annex60.Utilities.Psychrometrics.WetBul_pTX? If not, then the fix of #474 also needs to be applied to this model.

@mwetter
Copy link
Contributor

mwetter commented Oct 14, 2016

@thorade , @mlauster
Can you please comment on this so we can process the issue.

@mlauster
Copy link
Member

Removing should be fine for Aachen.

@thorade
Copy link
Member

thorade commented Oct 18, 2016

Removing one of the two is fine for UdK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants