Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values for Carnot chiller/heat pumps can violate 2nd law #497

Closed
mwetter opened this issue Jul 28, 2016 · 6 comments · Fixed by #640
Closed

Default values for Carnot chiller/heat pumps can violate 2nd law #497

mwetter opened this issue Jul 28, 2016 · 6 comments · Fixed by #640

Comments

@mwetter
Copy link
Contributor

mwetter commented Jul 28, 2016

The Carnot_* heat pumps and chillers use as the default values for computing the Carnot effectiveness inlet and outlet temperatures for the condenser or evaporator.

At small temperature lifts, using inlet temperatures only can lead to a computation of the Carnot efficiency that is higher than the actual Carnot efficiency.

In a model, we observed that for the situation of using the inlet temperatures and having low lifts, the entropy generated by the chiller was negative, which is a violation of the 2nd law. Therefore, the default values should be changed to using the outlet temperatures, which is a more conservative assumption that leads to lower Carnot efficiencies, and ensures that the 2nd law is not violated.

@mwetter
Copy link
Contributor Author

mwetter commented Jul 30, 2016

I added an entropy flow rate sensor that can be used for the validation. What remains to be done is

  • Change the default values of the temperatures used to compute the Carnot efficiency to be the volume temperature or the port_b temperatures.
  • Add validation tests that show that for small temperature lifts, the 2nd law is no longer violated.

@mwetter
Copy link
Contributor Author

mwetter commented Nov 19, 2016

The plot below shows that for the chiller model in which the inlet temperatures are used to compute the Carnot efficiency (instance chi_a), if the temperature lift is small, entropy is generated which violates the second law. I therefore recommend:

  • that the model is changed by removing the options of what temperature is used to compute the Carnot efficiency, and always use the outlet temperature.
  • Update the regression tests accordingly for the new model.
  • Remove the type Annex60.Fluid.Types.EfficiencyInput as it is only used in the Carnot heat pumps for the option that I propose to remove.

carnot_teva_2ndlaw

@mwetter
Copy link
Contributor Author

mwetter commented Dec 1, 2016

@mlauster , @thorade , @Mathadon
Please let me know if you agree with the three proposed items above from Nov. 19. I will then implement the changes and make a pull request.

@Mathadon
Copy link
Member

Mathadon commented Dec 2, 2016

I agree.

Maybe Annex60.Fluid.Types.EfficiencyInput may be used in the new heat pump model. But I doubt it :)

@mlauster
Copy link
Member

mlauster commented Dec 4, 2016

Sounds like a worthwhile improvement, no objections from Aachen side.

@thorade
Copy link
Member

thorade commented Dec 8, 2016

No objections, sounds reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants