Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential damper parameters and example #544

Closed
dhblum opened this issue Oct 12, 2016 · 2 comments
Closed

Exponential damper parameters and example #544

dhblum opened this issue Oct 12, 2016 · 2 comments

Comments

@dhblum
Copy link
Contributor

dhblum commented Oct 12, 2016

The use_v_nominal, v_nominal, and A parameters in Fluid.Actuators.Dampers.Exponential can be confusing, particularly as illustrated in Examples.Damper where both A and v_nominal have values of 1.

  • Propose removing parameters use_v_nominal and v_nominal, and having m_flow_nominal/rho_default/1 as the default value in A.
  • Propose changing Examples.Damper to remove the specifier of A=1.

ASHRAE 825-RP gives a range of reasonable values for k0 and k1, which could be used to ensure proper damper model performance.

  • Propose adding an assert statement to the values of parameters k1 and k0 to ensure they are within the range of those reported in ASHRAE 825-RP.

No tests for when the parameter linearized=True.

  • Propose changing Examples.Damper by adding a damper in parallel to res with linearized=True to compare the performance.
@mwetter
Copy link
Contributor

mwetter commented Oct 12, 2016

These are all good changes.

@Mathadon
Copy link
Member

closed through #545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants