Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setScores() accepts all kinds of data types #5

Closed
IbrahimNM opened this issue Apr 17, 2019 · 1 comment
Closed

setScores() accepts all kinds of data types #5

IbrahimNM opened this issue Apr 17, 2019 · 1 comment
Assignees
@IbrahimNM
Labels
bug Something isn't working Critical Critical Bug

Comments

@IbrahimNM
Copy link
Owner

setScores() should only accept a 'np.ndarray' data type.
@IbrahimNM IbrahimNM added the bug Something isn't working label Apr 17, 2019
@IbrahimNM IbrahimNM self-assigned this Apr 17, 2019
@IbrahimNM IbrahimNM added the Critical Critical Bug label Apr 24, 2019
@IbrahimNM
Copy link
Owner Author

Since setScore() scope is going to be private, and the function will no be called from outside of the class, there is no need to validate the data type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IbrahimNM IbrahimNM

Labels
bug Something isn't working Critical Critical Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@IbrahimNM