[kiel] Drop Jetifier #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
com.android.support:support-compat is conflicting with androidx.core:core-ktx and the culprit is "com.github.florent37:glidepalette"
samples/build.gradle
Outdated
| implementation "com.github.bumptech.glide:glide:$versions.glideVersion" | ||
| implementation "com.github.florent37:glidepalette:$versions.glidePaletteVersion" | ||
| implementation ("com.github.bumptech.glide:glide:$versions.glideVersion") | ||
| implementation ("com.github.florent37:glidepalette:$versions.glidePaletteVersion"){ |
There was a problem hiding this comment.
We may completely delete this left over dependency and its version.
There was a problem hiding this comment.
Sure! I didn't remove it because I thought you're using it
ibrahimyilmaz
approved these changes
Aug 29, 2020
|
Could you also add a comment about dropping Jetifier to ### Development
- Your comment
### Tahat(1.2.1) |
|
Sure! I'll just push it in this branch. wait wait what's Tahat(1.2.1) ? Update: Sorry I get it now lol |
Closed
|
@ibrahimyilmaz Done updating CHANGELOG.md |
implementation ("com.github.florent37:glidepalette:$versions.glidePaletteVersion")
We can merge this directly =) |
|
Sure I'll remove it |
|
We have done it! Thank you for your effort and contribution✌️. |
|
Nice! Thanks also! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed android.enableJetifier in settings.gradle also fixed import conflicts
This PR is related to #67