Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError from gateway timeouts #378

Open
mshriver opened this issue Aug 8, 2022 · 3 comments
Open

TypeError from gateway timeouts #378

mshriver opened this issue Aug 8, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request frontend

Comments

@mshriver
Copy link
Contributor

mshriver commented Aug 8, 2022

image

When filtering metadata fields like metadata.SomethingVersion for semantic versions like 1.2.3, a TypeError is produced, and no results fetched.

@rsnyman suggested these values are getting processed as floats, and the filter is trying to typecast. It should be interpreted as a string.

@mshriver
Copy link
Contributor Author

mshriver commented Aug 8, 2022

I'm unable to reproduce the error with local ibutsu having results with this metadata field set (X.Y, X.Y.Z, and X.Y.Z.ZZ formats).

Filtering works as expected

@mshriver
Copy link
Contributor Author

mshriver commented Aug 9, 2022

I've now observed different behavior on ibutsu, with no changes to the production containers from when this was written.

The mentioned filters now work intermittently, but will still cause type errors. Still unable to actually reproduce locally, even after loading results that didn't contain the metadata field being searched.

@mshriver
Copy link
Contributor Author

Alright, so some sanity has been found after some digging, learning, and a conversation with @rsnyman.

The root of this issue is the gateway timeout in the haproxy route in OCP. The backend/api query is taking too long, and the route times out and throws a 504.

The HttpClient functions, and fetch, aren't setup to cleanly handle this, so a TypeError occurs in the frontend.

Three actions are planned in order to better deal with this:

  1. Modify the OCP template spec for the backend route to increase the timeout
  2. Optimize/Improve performance of the result queries
  3. Better handling of potential gateway timeouts in the result-list page

@mshriver mshriver changed the title TypeError from floatish filtering TypeError from gateway timeouts Aug 10, 2022
@rsnyman rsnyman added bug Something isn't working enhancement New feature or request frontend labels Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request frontend
Projects
None yet
Development

No branches or pull requests

2 participants