Refactor to use \MongoClient instead of deprecated \Mongo #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| if ($obj instanceof MongoId) { | ||
| return $obj; | ||
| } | ||
|
|
||
| if (is_int($obj)) { |
There was a problem hiding this comment.
Hmmm, not certain about this -- this function should always return a MongoId -- why return an integer?
There was a problem hiding this comment.
There's that case when you use incremental IDs in Mongo DB, using Doctrine ODM or using your own library (especially when migrating data from structured databases)
That's why I added the is_int check and return
|
Refactor looks good, much cleaner -- but I have a couple concerns, let me know your thoughts. |
|
@ibwhite any updates? |
|
@ahmedmhmd I'm sorry I left you hanging so long on this one. I've merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.