Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Bars Patcher for sound files + problems. #2

Open
JKDos opened this issue Oct 30, 2022 · 1 comment
Open

Automatic Bars Patcher for sound files + problems. #2

JKDos opened this issue Oct 30, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@JKDos
Copy link

JKDos commented Oct 30, 2022

ABP = Automatic Bars Patcher

So there's 2 things to address here.

  1. The ABP asks for the Original BWAV file. This is a problem because only Stream/BGM really have original BWAVs. Sound effects for everything in the game exist only in the respective BARS files.

I wrote a Python script that will parse a BARS file and extract all BWAVs, so I actually got my hands on what is technically THE original BWAV file to satisfy the ABP.

  1. Whether using ABP or the old online one here (https://smashcustommusic.net/onlinetools/bars-patcher/), the newly patched BARS file does not include my custom BWAV. It contains what appears to be the original BWAV file.....however, it's distorted sounding.

Since ABP asks for an original BWAV, what is the appropriate way to patch BARS files for sound effects? If I did it correctly by extracting the BWAV from the BARS file and feeding it to ABP, what is the cause for the new BARS file not including the new BWAV file, but a distorted copy of the original?

@ic-scm
Copy link
Owner

ic-scm commented Oct 30, 2022

This BARS patcher was only written to replace the headers of BWAV files stored in BARS archives, as a solution to replacing standalone BWAV files with custom ones, in games where the game reads BWAV headers from a BARS archive that contains only the headers of the corresponding files, while continuing to read the actual audio data from the standalone BWAV files. It was not intended for replacing entire BWAV files stored in BARS archives. However, once I find the time, I might implement this functionality.

@ic-scm ic-scm added the enhancement New feature or request label Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants