One test fails with ruby 1.9.3

[bkabrda]

Hi,
one of ical's test fails for me, here is the test output:

1. Failure:
   test_property_parameters(TestComponent) [/home/bkabrda/rpmbuild/BUILDROOT/rubygem-icalendar-1.1.6-2.fc16.x86_64/usr/share/gems/gems/icalendar-1.1.6/test/test_parameter.rb:31]:
   <{"ALTREP"=>[""http://my.language.net""], "LANGUAGE"=>["SPANISH"]}> expected but was
   <{"ALTREP"=>[]}>.

ruby -v: ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-linux]

Any ideas?
Thanks,
Bohuslav.

[sdague]

On 12/12/2011 06:43 AM, Bohuslav Kabrda wrote:

Hi,
one of ical's test fails for me, here is the test output:

1. Failure:
   test_property_parameters(TestComponent) [/home/bkabrda/rpmbuild/BUILDROOT/rubygem-icalendar-1.1.6-2.fc16.x86_64/usr/share/gems/gems/icalendar-1.1.6/test/test_parameter.rb:31]:
   <{"ALTREP"=>[""http://my.language.net""], "LANGUAGE"=>["SPANISH"]}> expected but was
   <{"ALTREP"=>[]}>.

ruby -v: ruby 1.9.3p0 (2011-10-30 revision 33570) [x86_64-linux]

Is this one of the tests where hash order matters? That seems to change
in interesting ways between versions of ruby.

Also, what distribution is this on?

-Sean

Sean Dague Learn about the Universe with the
sean at dague dot net Mid-Hudson Astronomical Association
http://dague.net http://midhudsonastro.org

[bkabrda]

I'm rebuilding gems with Ruby 1.9.3 for Fedora Rawhide - the new version should land there soon.

I don't think that order matters:
"cals.first.events.first.summary" returns "//my.language.net";LANGUAGE=SPANISH:This is a test summary.", which seems ok, but when you call the ical_params method on it (like "cals.first.events.first.summary.ical_params"), it returns the <{"ALTREP"=>[]}>.

Bohuslav

[ericcf]

The test passes if you either reverse the hash:

{"LANGUAGE"=>["SPANISH"], "ALTREP"=>["\"http://my.language.net\""]}

or add escaped double quotes to SPANISH:

{"ALTREP"=>["\"http://my.language.net\""], "LANGUAGE"=>["\"SPANISH\""]}

The problem is here: https://github.com/sdague/icalendar/blob/master/lib/icalendar/parser.rb#L199. It does not correctly parse lines like this:

SUMMARY;ALTREP="http://example.com/foo";LANGUAGE=en-US:This is a summary.

The problem is the : in http: because it is a control character within a double-quoted string. I think the regular expressions need some rewriting.

I played around with it, but haven't come up with a good solution yet.

[sdague]

I've got what I think is a workable solution in tree, it seems to support the existing tests. Will be released in 1.2.1