Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to Swift 2.0 #23

Closed
wants to merge 1 commit into from
Closed

Conversation

VasuLaroiya
Copy link

I converted the SwiftSpinner.swift file to Swift 2.0. I also converted the Demo Project to a Xcode 7 project. The pod file wasn’t working for me so I changed it to get the SwiftSpinner from the cocoapod you have setup.

@icanzilb
Copy link
Owner

icanzilb commented Jul 3, 2015

I appreciate it but Swift 2.0 is still beta so your changes will break people's projects who are using the latest stable Xcode

@VasuLaroiya
Copy link
Author

I understand but you can make a new branch for swift 2.0 so people who are using swift 2.0 they can use your project without any worry.

On Jul 3, 2015, at 3:48 PM, Marin Todorov notifications@github.com wrote:

I appreciate it but Swift 2.0 is still beta so your changes will break people's projects who are using the latest stable Xcode


Reply to this email directly or view it on GitHub #23 (comment).

@icanzilb
Copy link
Owner

icanzilb commented Jul 4, 2015

ok, let me check how can I do that on github

@icanzilb
Copy link
Owner

icanzilb commented Jul 4, 2015

the project doesn't compile on xcode7, imports some kind of 3rd party libraries, doesn't use the local pod source

@icanzilb icanzilb closed this Jul 4, 2015
@VasuLaroiya
Copy link
Author

Yeah the pod file you have setup doesn't work. If you link the file SwiftSpinner that is in the main folder it will work.

Sent from my iPhone

On Jul 4, 2015, at 2:16 AM, Marin Todorov notifications@github.com wrote:

the project doesn't compile on xcode7, imports some kind of 3rd party libraries, doesn't use the local pod source


Reply to this email directly or view it on GitHub.

@ndmeiri
Copy link

ndmeiri commented Jul 14, 2015

@icanzilb Can we reopen this please? Those of us who are using SwiftSpinner in our Swift 2.0 projects can't compile our projects unless we fork this repo or stop using the control altogether. As @VasuLaroiya mentioned, you can create a branch for just the Swift 2.0 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants