Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't ios8 already have this? #6

Closed
Esqarrouth opened this issue Jul 21, 2015 · 9 comments
Closed

Doesn't ios8 already have this? #6

Esqarrouth opened this issue Jul 21, 2015 · 9 comments

Comments

@Esqarrouth
Copy link

I've been working with the core iOS methods and the examples you gave in EasyAnimation is the same as standard iOS ones. Am I missing something?

@icanzilb
Copy link
Owner

The very first example in the readme works on iOS8 by default - yes. Or do you mean something else?

@Esqarrouth
Copy link
Author

I think the readme isn't clear on what is an iOS default and what EasyAnimation brings to the table

@fatuhoku
Copy link

Yeah not clear to me at all what EasyAnimation as a library does

@icanzilb
Copy link
Owner

there's a readme ... not sure what more i can do

@Esqarrouth
Copy link
Author

The examples are of animateWithDuration which was introduced in iOS4.

The example says normally its X, but with EasyAnimation its Y.
But in real world normally its Y, so whats the benefit of EasyAnimation?

@icanzilb
Copy link
Owner

read the readme of this repository, thanks

@Esqarrouth
Copy link
Author

Yes I read the readme.

This piece here says that animations without EasyAnimations suck:
http://i.imgur.com/uck5xPA.png

I tried this, it took me 1 minute for this experiment and it doesn't suck:
http://i.imgur.com/06Cuv6W.gif

I didn't need to write the whole

let anim = CABasicAnimation(keyPath: "position.x")
anim.fromValue = 100.0
anim.toValue = 200.0
anim.duration = 2.0
view.layer.addAnimation(anim, forKey: nil)

thing as you see in the code.

So is your readme basically lying? From my point of view what you are saying is exactly like this:

Normal UIView:
let myview = UIView()
myview.thisShouldWork = true
myview.thisIsAView = true
myview.thisViewStartsFromX = 10
myview.thisViewStartsFromY = 10
myview.thisViewWidth = 10
myview.thisViewHeight = 10

Heres EasyView:

let myview = UIView(frame: CGRect(10,10,10,10))

tada, it works yey!!

@Esqarrouth
Copy link
Author

If you didn't understand what I say, let me make it more clearer:

Your readme gives me no relevant/true information, its just a useless piece of document.

I haven't checked your code btw, I am just talking about the readme

@icanzilb
Copy link
Owner

dude I answered you 2 months ago - you are right. this piece of code is there for illustrative purpose

Repository owner locked and limited conversation to collaborators Oct 19, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants