Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clean-up of EmitterBase and its children to make it as easy as possible to extend.
Resolves #98
Changelog Description
TODO
_rng
attribute and put it in the children, as not all emitters may need it_archive
a public attributeseed
parameter (without_rng
, there is no need forseed
)_lower_bounds
and_upper_bounds
solution_dim
andbounds
should be okay to keepbatch_size
Optimizer
keep track of the number of solutions generatedtell()
makes sense, but its docstring should be updated to be more clear on what it doesQuestions
Status
CONTRIBUTING.md.
yapf
pytest
(tox
is run in CI/CD)pylint