Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dependency issues in tests #139

Merged
merged 2 commits into from Jul 2, 2021
Merged

Fix dependency issues in tests #139

merged 2 commits into from Jul 2, 2021

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Jul 2, 2021 •
edited

Description

We are running into some failures with tests. This PR should fix the problems.

Changelog Description

Fix dependency issues in tests (#139)

TODO

  • Freeze torch versions in tutorials
  • Remove pip install -U pip step in tox - this was failing on Windows

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest (tox is run in CI/CD)
  • I have linted my code with pylint
  • This PR is ready to go

@btjanaka btjanaka changed the title Freeze torch versions in tutorials Fix dependency issues in tests Jul 2, 2021
@btjanaka btjanaka merged commit c1ba194 into master Jul 2, 2021
@btjanaka btjanaka deleted the tutorial-deps branch July 2, 2021 09:16
@btjanaka btjanaka added this to the v0.4.0 milestone Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@btjanaka