Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checks for optimizer array and list shapes #166

Merged
merged 4 commits into from Jul 16, 2021
Merged

Add checks for optimizer array and list shapes #166

merged 4 commits into from Jul 16, 2021

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Jul 16, 2021 •
edited

Description

Add checks for the size of emitter_kwargs (when it is a list), as well as for the arrays passed to tell().

Changelog Description

Add checks for optimizer array and list shapes (#166)

TODO

  • Check emitter_kwargs length
  • Check solutions, objective_values, behavior_values length in optimizer.tell()
  • Add tests

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • This PR is ready to go

@btjanaka btjanaka changed the title Add checks for optimizer arguments Add checks for optimizer array and list shapes Jul 16, 2021
@btjanaka btjanaka merged commit 51cc071 into master Jul 16, 2021
@btjanaka btjanaka deleted the optimizer-check branch July 16, 2021 06:21
@btjanaka btjanaka added this to the v0.4.0 milestone Jul 16, 2021
@btjanaka btjanaka added the API label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@btjanaka