Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'visualize' extra and remove 'all' extra #183

Merged
merged 6 commits into from Mar 11, 2022
Merged

Add 'visualize' extra and remove 'all' extra #183

merged 6 commits into from Mar 11, 2022

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Mar 11, 2022 •
edited

Description

Working towards a pyribs that can be installed with just

pip install ribs

Then to add on extras, users can specify e.g.

pip install ribs[visualize]

TODO

  • Modify setup.py

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka changed the title Restructure extras by removing 'all' and adding 'visualize' Add 'visualize' extra and remove 'all' extra Mar 11, 2022
@btjanaka btjanaka mentioned this pull request Mar 11, 2022
Closed
4 tasks
@btjanaka btjanaka merged commit 0572c17 into master Mar 11, 2022
@btjanaka btjanaka deleted the deps branch March 11, 2022 23:56
@btjanaka btjanaka added this to the v0.5.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@btjanaka