Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use integer indices in archives #185

Merged
merged 23 commits into from Mar 26, 2022
Merged

Only use integer indices in archives #185

merged 23 commits into from Mar 26, 2022

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Mar 14, 2022

Description

Using a single integer for archive indices makes it easier to reason about the indices in ArchiveBase.

TODO

  • Switch to integer index in GridArchive
  • Switch to integer index in SlidingBoundariesArchive
  • Simplify ArchiveBase to always use integer indices
  • Switch _occupied_indices to a fixed-size numpy array (with dimension storage_dim) and remove _occupied_indices_cols
  • Only return single index column in as_pandas
  • Simplify archives to handle the new simplified ArchiveBase
  • Add and test methods for raveling and unraveling indices in GridArchive and SlidingBoundariesArchive -> Added but will test and document in followup PR
  • Fix visualization tools
  • Fix tests
  • Fix ArchiveDataFrame
  • Settle on data type for indices (likely np.int64 since that is what numpy converts int to) -> just int since this depends on the system
  • Clean up TODOs
  • Update documentation

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka changed the title Flatten indices across archives Make archives only use integer indices Mar 14, 2022
@btjanaka btjanaka changed the title Make archives only use integer indices Only use integer indices in archives Mar 14, 2022
@btjanaka btjanaka merged commit a7bd3d1 into master Mar 26, 2022
@btjanaka btjanaka deleted the flatten-indices branch March 26, 2022 08:01
@btjanaka btjanaka added this to the v0.5.0 milestone Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant