Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace get_random_elite() with batched sample_elites() method #192

Merged
merged 12 commits into from Mar 28, 2022

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Mar 26, 2022

Description

This PR replaces get_random_elite with a sample_elites method which samples an entire batch of elites from the archive rather than just a single elite. This allows the emitter to operate more quickly since they do not have to call get_random_elite one at a time. We have decided to rename the method so that we are guaranteed to break people who still use get_random_elite().

TODO

  • Implement sample_elites
  • Remove get_random_elite benchmarks (since sample_elites is batched, it is much faster)
  • Test sample_elites
  • Fix emitters
  • Fix tests

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md.
  • This PR is ready to go

@btjanaka btjanaka added this to the v0.5.0 milestone Mar 28, 2022
@btjanaka btjanaka merged commit 80655a2 into master Mar 28, 2022
@btjanaka btjanaka deleted the sample-elites branch March 28, 2022 00:50
@btjanaka btjanaka added the API label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant