New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove initialize method from archives #200
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove the call to initialize
in the Optimizer, and remove/fix any tests. Also, try running the example code from the pyribs home page to make sure everything still works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor
Description
I put the solution_dim (int): Dimension of the solution space. As the comment under args above the stuff. I put the solution_dim argument s.t. The new prototype for init in _archive_base is def init(self, cells, behavior_dim, solution_dim, seed=None, dtype=np.float64) for archive_base.
The new prototype for cvt_archive is def init(self,
cells,
ranges,
solution_dim,
seed=None,
dtype=np.float64,
samples=100_000,
custom_centroids=None,
k_means_kwargs=None,
use_kd_tree=False,
ckdtree_kwargs=None)
The new prototype for grid_archive is def init(self, dims, ranges, solution_dim, seed=None, dtype=np.float64)
I put solution_dim as a required (non-default) arg before seed in every instance.
TODO
__init__.py
that says ".. note:: After construction, each archive must be initialized by callingits
initialize()
method before it can be used"decorator
from theinstall_requires
insetup.py
since it was only used forrequire_init
Questions
Status
yapf
pytest
pylint
HISTORY.md
.