Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tutorials/Examples #253

Merged
merged 52 commits into from Oct 2, 2022
Merged

Fix Tutorials/Examples #253

merged 52 commits into from Oct 2, 2022

Conversation

itsdawei
Copy link
Collaborator

@itsdawei itsdawei commented Aug 15, 2022

Description

Fix tutorials that were broken by previous changes.

TODO

Questions

  • Should we add jupyter notebook to setup.py, i.e. pip install -e pyribs[jupyter] -> no

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@itsdawei itsdawei marked this pull request as ready for review August 16, 2022 06:35
@itsdawei itsdawei changed the title Fix Tutorials Fix Tutorials/Examples Aug 16, 2022
@btjanaka
Copy link
Member

btjanaka commented Oct 2, 2022

Note that the tutorials were failing due to kernelspec errors. This seems to be related to using the wrong Python version to open the notebooks -- see voila-dashboards/voila#267

I fixed this by opening the notebooks in jupyter lab with Python 3.7 and saving them after jupyterlab automatically corrected the kernelspec.

@btjanaka btjanaka mentioned this pull request Oct 2, 2022
8 tasks
@btjanaka btjanaka merged commit 8818e49 into master Oct 2, 2022
@btjanaka btjanaka deleted the fix-tutorials branch October 2, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants