Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape checks to tell() methods #269

Merged
merged 18 commits into from Nov 22, 2022
Merged

Add shape checks to tell() methods #269

merged 18 commits into from Nov 22, 2022

Conversation

itsdawei
Copy link
Collaborator

@itsdawei itsdawei commented Nov 13, 2022 •
edited

Description

Add shape checks to tell() and tell_dqd().

TODO

  • Add shape checks
  • Add tests

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

btjanaka
btjanaka approved these changes Nov 16, 2022
View reviewed changes
ribs/emitters/_evolution_strategy_emitter.py Outdated Show resolved Hide resolved
tests/emitters/emitter_base_test.py Outdated Show resolved Hide resolved
btjanaka
btjanaka approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@btjanaka btjanaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes

ribs/_utils.py Outdated Show resolved Hide resolved
ribs/_utils.py Outdated Show resolved Hide resolved
ribs/emitters/_evolution_strategy_emitter.py Outdated Show resolved Hide resolved
ribs/emitters/_gradient_arborescence_emitter.py Outdated Show resolved Hide resolved
tests/emitters/emitter_base_test.py Outdated Show resolved Hide resolved
@itsdawei itsdawei merged commit fe36582 into master Nov 22, 2022
@itsdawei itsdawei deleted the shape-check-tell branch November 22, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btjanaka btjanaka btjanaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itsdawei @btjanaka