Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedulers warn if no solutions are inserted into archive #320

Merged
merged 10 commits into from Feb 17, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Feb 16, 2023

Description

Solutions may not be inserted into the archive if the threshold_min is too high. This can lead to unexpected behavior. For instance, GaussianEmitter with an initial set of solutions will keep producing that same set of solutions, and archive metrics like obj_max will be None. We shouldn't throw an error when this happens as users may decide they want this, but a warning is nice.

TODO

  • Warn in Scheduler
  • Warn in BanditScheduler
  • Test Scheduler warning
  • Test BanditScheduler warning

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka changed the title Warn users when no solutions were inserted into archive Warn users when no solutions are inserted into archive Feb 16, 2023
@btjanaka btjanaka changed the title Warn users when no solutions are inserted into archive Schedulers warn if no solutions are inserted into archive Feb 17, 2023
Copy link
Collaborator

@itsdawei itsdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[fire][fire][fire]

@btjanaka btjanaka merged commit b90a188 into master Feb 17, 2023
@btjanaka btjanaka deleted the feat/archive-warning branch February 17, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants