Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GradientArborescenceEmitter bounds #321

Merged
merged 7 commits into from Feb 17, 2023
Merged

Conversation

btjanaka
Copy link
Member

Description

Solution space bounds remain an open problem for DQD algorithms, and it is unclear that our implementation will create the correct behavior. Thus, we are removing the bounds handling for the time being.

TODO

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

Copy link
Collaborator

@itsdawei itsdawei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[insert fire emoji]

@btjanaka btjanaka merged commit 5cd268e into master Feb 17, 2023
@btjanaka btjanaka deleted the feat/delete-dqd-bounds branch February 17, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants