Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that emitters passed in are lists/iterables in scheduler #341

Merged
merged 3 commits into from Jul 14, 2023

Conversation

itsdawei
Copy link
Collaborator

@itsdawei itsdawei commented Jul 14, 2023

Description

A potentially common error is for users to pass in a single emitter and receive a confusing error message about the emitter not having the method __len__. This PR makes the error message more clear.

TODO

Questions

Status

  • I have read the guidelines in CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in HISTORY.md
  • This PR is ready to go

@itsdawei itsdawei requested a review from btjanaka July 14, 2023 19:57
@itsdawei itsdawei merged commit 82fac93 into master Jul 14, 2023
9 checks passed
@itsdawei itsdawei deleted the scheduler-ask branch July 14, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants