Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement ArchiveBase using ArrayStore #399

Merged
merged 46 commits into from Nov 7, 2023
Merged

Reimplement ArchiveBase using ArrayStore #399

merged 46 commits into from Nov 7, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Nov 3, 2023

Description

This PR refactors the ArchiveBase to place data in ArrayStore rather than in separate NumPy arrays. This should make the archive more flexible and easier to extend in the future.

While flexibility is the end goal, note that this PR is only a refactor; thus, no API changes are being made. As a result, tests will mostly remain the same.

The exception is the creation of a private ribs.archives._transforms module, for which we do introduce new tests. This module should be considered unstable for now, but once it seems more stable, we can make it public.

TODO

  • Modify ArchiveBase
  • Update SlidingBoundariesArchive
  • Create private transforms module
  • Test transforms
  • Fix ArchiveBase tests where appropriate

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka merged commit cc7051c into master Nov 7, 2023
18 checks passed
@btjanaka btjanaka deleted the archivebase branch November 7, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant