Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace status and value with add_info #430

Merged
merged 10 commits into from Nov 29, 2023
Merged

Replace status and value with add_info #430

merged 10 commits into from Nov 29, 2023

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Nov 28, 2023

Description

To make the, more flexible, add() methods now return add_info instead of separate status_batch and value_batch. This will make it easy to return more info in the future.

Correspondingly, emitters now take in add_info instead of separate status_batch and value_batch arguments, and calls to add() have been fixed in the schedulers.

TODO

  • Update in ArchiveBase
  • Update in SlidingBoundariesArchive
  • Update calls in scheduler
  • Update emitters to take in add_info
  • Fix tests

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md
  • I have formatted my code using yapf
  • I have tested my code by running pytest
  • I have linted my code with pylint
  • I have added a one-line description of my change to the changelog in
    HISTORY.md
  • This PR is ready to go

@btjanaka btjanaka changed the title Return add_info as a dict in archive add method Replace status and value with add_info Nov 29, 2023
@btjanaka btjanaka merged commit efd0ec8 into master Nov 29, 2023
4 checks passed
@btjanaka btjanaka deleted the add-info branch November 29, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant