New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NumPy SeedSequence in emitters #431

Merged

btjanaka merged 1 commit into master from rng

Nov 29, 2023

Member

btjanaka commented Nov 29, 2023

Description

This PR uses SeedSequence to seed the optimizer in emitters, rather than drawing integers from the current RNG. The ideal method would be to use rng.spawn (https://numpy.org/doc/stable//reference/random/generated/numpy.random.Generator.spawn.html#numpy.random.Generator.spawn) to create a child RNG, but this feature is only in NumPy 1.25, which only supports Python 3.9+ (we use 3.8+).

TODO

Questions

Status

I have read the guidelines in
CONTRIBUTING.md
I have formatted my code using yapf
I have tested my code by running pytest
I have linted my code with pylint
I have added a one-line description of my change to the changelog in
HISTORY.md
This PR is ready to go


          Use NumPy SeedSequence in emitters

8d49757

btjanaka merged commit 0c38b7a into master

17 checks passed

btjanaka deleted the rng branch

November 29, 2023 04:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment