Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI/CD #83

Merged
merged 4 commits into from Feb 8, 2021
Merged

Improve CI/CD #83

merged 4 commits into from Feb 8, 2021

Conversation

btjanaka
Copy link
Member

@btjanaka btjanaka commented Feb 7, 2021

Description

Add testing on Windows and MacOS. Due to concerns with runtime, only added tests for Python 3.7 for these OS's. We may add tests for 3.6 and 3.8 in the future. Resolves #72

Changelog Description

Added testing for Windows and MacOS (on Python 3.7 only) (#83)

TODO

Questions

Status

  • I have read the guidelines in
    CONTRIBUTING.md.
  • I have formatted my code using yapf
  • I have tested my code by running pytest (tox is run in CI/CD)
  • I have linted my code with pylint
  • This PR is ready to go

@btjanaka
Copy link
Member Author

btjanaka commented Feb 8, 2021

A possible issue here is that mac and windows are in higher demand and thus take longer to start jobs on.

@btjanaka btjanaka merged commit 7f54272 into master Feb 8, 2021
@btjanaka btjanaka deleted the ci branch February 8, 2021 01:36
@btjanaka btjanaka restored the ci branch February 8, 2021 01:42
@btjanaka btjanaka mentioned this pull request Feb 8, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Test Mac and Windows in CI/CD
1 participant